Skip to content

fix: propagate Kubernetes client arguments - #2027

Merged
enoodle merged 1 commit into
kai-scheduler:mainfrom
enoodle:fix/operator-k8s-client-config-args
Aug 7, 2026
Merged

fix: propagate Kubernetes client arguments#2027
enoodle merged 1 commit into
kai-scheduler:mainfrom
enoodle:fix/operator-k8s-client-config-args

Conversation

@enoodle

@enoodle enoodle commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Description

Propagates configured Kubernetes client QPS and burst arguments to admission, queue-controller, and podgroup-controller deployments.

Fixes the shared argument helper returning an unobserved slice. Adds coverage for default arguments and queue-controller override propagation.

Related Issues

N/A

Checklist

  • Self-reviewed
  • Added/updated tests (if needed)
  • Updated documentation (if needed)
  • Added a changelog fragment via make changelog (or applied the skip-changelog label). Do not edit CHANGELOG.md directly — pending fragments are folded into it at release time.

Breaking Changes

None.

Additional Notes

None.

@enoodle
fix: propagate Kubernetes client arguments
386b7e9 
Signed-off-by: Erez Freiberger <enoodle@gmail.com>
@enoodle enoodle closed this Aug 7, 2026
@enoodle enoodle reopened this Aug 7, 2026
@enoodle
enoodle enabled auto-merge August 7, 2026 08:24
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Total coverage: 54.5% -> 54.5% (delta 0.00%)

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/kai-scheduler/KAI-scheduler/pkg/operator/operands/admission 86.30% (ø)
github.com/kai-scheduler/KAI-scheduler/pkg/operator/operands/common 78.44% (-0.47%) 👎
github.com/kai-scheduler/KAI-scheduler/pkg/operator/operands/pod_group_controller 77.78% (ø)
github.com/kai-scheduler/KAI-scheduler/pkg/operator/operands/queue_controller 76.15% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/kai-scheduler/KAI-scheduler/pkg/operator/operands/admission/resources.go 89.92% (ø) 119 107 12
github.com/kai-scheduler/KAI-scheduler/pkg/operator/operands/common/common.go 77.07% (-0.49%) 157 (+1) 121 36 (+1) 👎
github.com/kai-scheduler/KAI-scheduler/pkg/operator/operands/pod_group_controller/resources.go 85.48% (ø) 62 53 9
github.com/kai-scheduler/KAI-scheduler/pkg/operator/operands/queue_controller/resources.go 81.48% (ø) 81 66 15

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/kai-scheduler/KAI-scheduler/pkg/operator/operands/admission/resources_test.go
  • github.com/kai-scheduler/KAI-scheduler/pkg/operator/operands/pod_group_controller/pod_group_controller_test.go
  • github.com/kai-scheduler/KAI-scheduler/pkg/operator/operands/queue_controller/queue_controller_test.go

@enoodle
enoodle added this pull request to the merge queue Aug 7, 2026
Merged via the queue into kai-scheduler:main with commit d5bc503 Aug 7, 2026
20 checks passed
@enoodle
enoodle deleted the fix/operator-k8s-client-config-args branch August 7, 2026 10:40
@KaiPilotBot

KaiPilotBot commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

📝 Changelog fragment recorded

Thanks! This PR added the changelog fragment(s) below. Pending fragments are folded into CHANGELOG.md at release time, so it was intentionally not modified by this PR — your entry will appear in the next release:

@KaiPilotBot

KaiPilotBot commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Backport failed for v0.9, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin v0.9
git worktree add -d .worktree/backport-2027-to-v0.9 origin/v0.9
cd .worktree/backport-2027-to-v0.9
git switch --create backport-2027-to-v0.9
git cherry-pick -x 386b7e999afb473b07fec1725a1c41827f406f2a

@KaiPilotBot

KaiPilotBot commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Backport failed for v0.12, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin v0.12
git worktree add -d .worktree/backport-2027-to-v0.12 origin/v0.12
cd .worktree/backport-2027-to-v0.12
git switch --create backport-2027-to-v0.12
git cherry-pick -x 386b7e999afb473b07fec1725a1c41827f406f2a

@KaiPilotBot

KaiPilotBot commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Backport failed for v0.14, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin v0.14
git worktree add -d .worktree/backport-2027-to-v0.14 origin/v0.14
cd .worktree/backport-2027-to-v0.14
git switch --create backport-2027-to-v0.14
git cherry-pick -x 386b7e999afb473b07fec1725a1c41827f406f2a

@KaiPilotBot KaiPilotBot mentioned this pull request Aug 7, 2026
Merged
@KaiPilotBot

KaiPilotBot commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Successfully created backport PR for v0.16:

@KaiPilotBot

KaiPilotBot commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Successfully created backport PR for v0.17:

@KaiPilotBot KaiPilotBot mentioned this pull request Aug 7, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidLif davidLif davidLif approved these changes

Assignees

No one assigned

Labels

backport v0.9 backport v0.12 backport v0.14 PRs that need backport to v0.14 branch backport v0.16 backport v0.17

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@enoodle @KaiPilotBot @davidLif